Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPT-1998 Добавление таргета для моков #129

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

mrandrewsmith
Copy link
Collaborator

Что сделано

  • Переименована библиотека ThirdParty в NodeKitThirdParty, дабы избежать конфликтов в будущем
  • Сделан таргет NodeKitMock с моками
  • Изменены модификаторы доступа в моках

@mrandrewsmith mrandrewsmith self-assigned this Apr 10, 2024
@mrandrewsmith mrandrewsmith changed the title SPT-1998 create mock target SPT-1998 Добавление таргета для моков Apr 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (c5e2ee8) to head (77a98d8).
Report is 1 commits behind head on 5.0.0.

Additional details and impacted files
@@           Coverage Diff           @@
##            5.0.0     #129   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files          82       82           
  Lines        1259     1259           
=======================================
  Hits         1151     1151           
  Misses        108      108           
Flag Coverage Δ
tests 91.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-integration-tests branch from 7f72987 to 65734f5 Compare April 10, 2024 19:06
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-make-mock-target branch from 8ccb83b to c927a83 Compare April 10, 2024 19:45
Copy link
Contributor

@NullIsOne NullIsOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь или в следующем ПР можно добавить инструкцию небольшую для нового таргета NodeKitMock.

Вроде моки публичных нод есть, но однозначного понятия нет как протестить какой-нибудь метод сервиса, например

func postDeactivate() -> Observer<Void> {
        return builder
            .route(.post, .deactivate)
            .build()
            .process()
    }

(Да это пример на старом NodeKit, он нужен для пояснения концепции использования)
builder у нас создает chain, цепочку нод.
URLChainsbuilder остался в этой версии, но теперь возвращает AsyncNode или AsyncStreamNode. Однако мока на него нет.
Сервисы как правило реализуют группу запросов, потому чтобы не создавать ручками в проекте мок URLChainsbuilder, лучше его включить в новый подпакет.

@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-integration-tests branch from 65734f5 to 7110bb1 Compare April 16, 2024 12:39
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-make-mock-target branch from c927a83 to babfb15 Compare April 16, 2024 12:43
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-integration-tests branch from 7110bb1 to c5e2ee8 Compare April 24, 2024 09:38
@mrandrewsmith mrandrewsmith changed the base branch from SPT-1998-integration-tests to 5.0.0 April 24, 2024 09:44
@mrandrewsmith mrandrewsmith force-pushed the SPT-1998-make-mock-target branch from babfb15 to 77a98d8 Compare April 24, 2024 09:45
@mrandrewsmith mrandrewsmith merged commit 8dafb97 into 5.0.0 Apr 24, 2024
1 check passed
@mrandrewsmith mrandrewsmith deleted the SPT-1998-make-mock-target branch May 13, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants